Add dismissed state (#866)

palantir · Oct 24, 2024 · fc09d7a · fc09d7a
1 parent 758ecc9
commit fc09d7a
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/server/handler/pull_request_review.go b/server/handler/pull_request_review.go
@@ -88,6 +88,10 @@ func (h *PullRequestReview) Handle(ctx context.Context, eventType, deliveryID st
 
 func (h *PullRequestReview) affectsApproval(reviewState pull.ReviewState, config *policy.Config) bool {
 	states := make(map[pull.ReviewState]struct{})
+
+	// Always process events for dismissed reviews because they can revert the overall approval or disapproval to a previous state
+	states[pull.ReviewDismissed] = struct{}{}
+
 	for _, rule := range config.ApprovalRules {
 		states[rule.Options.GetMethods().GithubReviewState] = struct{}{}
 	}