Populate PRELOADED_MODULES lazily #310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/python-language-server, @nanoant! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
nanoant
force-pushed
the
patch/populate-preloaded-modules-lazily
branch
from
47d6560 to
241950a
Compare
nanoant
changed the title
|
Thanks for your interest in palantir/python-language-server, @nanoant! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Otherwise we spend time populating PRELOADED_MODULES regardless if we use Rope or not.
nanoant
force-pushed
the
patch/populate-preloaded-modules-lazily
branch
from
241950a to
fdc261d
Compare
|
Closing this since you can now disable / configure preloaded module: https://github.com/palantir/python-language-server/blob/develop/pyls/plugins/preload_imports.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents wasting CPU/IO cycles when PRELOADED_MODULES are not going to be
used anyway, e.g. Rope is missing or disabled.
This is follow-up for #286 and #301