Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove chart from deprecated limit orders #11137

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 14, 2025

Screenshot 2025-01-14 at 12 18 54

currently it shows both as component and as modal which is a bug


PR-Codex overview

This PR focuses on simplifying the LimitOrders component by removing unused imports and state variables related to chart display, as well as adjusting the layout and rendering logic of the component.

Detailed summary

  • Removed unused import of AutoColumn, useExchangeChartManager, and PriceChartContainer.
  • Eliminated isChartDisplayed and isChartExpanded state variables.
  • Set isSideFooter to false.
  • Adjusted the Page and Flex components to reflect the removed chart logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 11:45am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 11:45am
blog ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 11:45am
bridge ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 11:45am
games ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 11:45am
gamification ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 11:45am
uikit ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 11:45am
ton ⬜️ Skipped (Inspect) Jan 14, 2025 11:45am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant