Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing page text translation on tables #11153

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 20, 2025


PR-Codex overview

This PR updates the pagination text in multiple components to use a translation function instead of string interpolation. This change enhances internationalization support for the pagination display.

Detailed summary

  • In apps/web/src/views/V3Info/components/PoolTable/index.tsx, changed <Text>{Page ${page} of ${maxPage}}</Text> to <Text>{t('Page %page% of %maxPage%', { page, maxPage })}</Text>.
  • In apps/web/src/views/V3Info/components/TokenTable/index.tsx, updated pagination text similarly.
  • In apps/web/src/views/V3Info/components/TransactionsTable/index.tsx, made the same change to the pagination text.
  • In apps/web/src/views/PoolDetail/components/Transactions/TransactionsTable.tsx, replaced the pagination text with the translation function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 4:19pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 4:19pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:19pm
blog ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:19pm
bridge ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:19pm
games ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:19pm
gamification ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:19pm
ton ⬜️ Skipped (Inspect) Jan 20, 2025 4:19pm

@memoyil memoyil requested a review from chef-ryan as a code owner January 20, 2025 15:56
@vercel vercel bot temporarily deployed to Preview – ton January 20, 2025 15:56 Inactive
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: fc5bee0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant