Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intermittent truncate hash crash #11180

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 8, 2025


PR-Codex overview

This PR enhances the truncateHash function in truncateHash.ts to include a type check for the address parameter, ensuring it is a string before proceeding with truncation.

Detailed summary

  • Updated the truncateHash function to check if address is a string.
  • If address is not a string or is falsy, it now returns an empty string.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 8:44am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 8:44am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 8:44am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 8:44am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 8:44am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 8:44am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 8:44am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ton ⬜️ Skipped (Inspect) Feb 8, 2025 8:44am

Copy link

changeset-bot bot commented Feb 8, 2025

⚠️ No Changeset found

Latest commit: ddf3120

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant