Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove old swap & liquidity code #11181

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 8, 2025


PR-Codex overview

This PR primarily focuses on the removal of the V3Swap module, along with its associated components, hooks, and utilities, while updating references to utilize a new structure for the Swap functionality.

Detailed summary

  • Deleted multiple files related to V3Swap.
  • Updated SwapPage to return an empty fragment.
  • Refactored imports to point to the new views/Swap structure.
  • Removed various hooks and components specific to V3Swap.
  • Introduced new types and utilities in the views/Swap directory.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 8, 2025

⚠️ No Changeset found

Latest commit: e123557

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:38pm
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:38pm
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:38pm
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:38pm
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:38pm
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:38pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 3:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ton ⬜️ Skipped (Inspect) Feb 8, 2025 3:38pm

Copy link
Collaborator Author

@memoyil memoyil Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

barrel exports prevents tree shaking

@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 09:44 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:34 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 15:01 Inactive
@memoyil memoyil changed the title refactor: Remove old swap code refactor: Remove old swap&liquidity code Feb 8, 2025
@memoyil memoyil changed the title refactor: Remove old swap&liquidity code refactor: Remove old swap & liquidity code Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant