Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Order v3 positions by tokenId desc in positions page #11184

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 9, 2025

This is especially good for user to see recently closed positions first


PR-Codex overview

This PR focuses on modifying the return value of the function in the file getAccountV3Positions.ts to sort the positions array based on the tokenId property in descending order.

Detailed summary

  • Changed the return statement to sort positions.
  • Introduced sorting logic using tokenId, defaulting to BigInt(0) if tokenId is null or undefined.
  • Adjusted the comparison to sort in descending order (higher tokenId first).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 9, 2025

⚠️ No Changeset found

Latest commit: 13e2ed3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 5:48pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Feb 9, 2025 5:48pm
blog ⬜️ Ignored (Inspect) Feb 9, 2025 5:48pm
bridge ⬜️ Ignored (Inspect) Feb 9, 2025 5:48pm
games ⬜️ Ignored (Inspect) Feb 9, 2025 5:48pm
gamification ⬜️ Ignored (Inspect) Feb 9, 2025 5:48pm
uikit ⬜️ Ignored (Inspect) Feb 9, 2025 5:48pm
ton ⬜️ Skipped (Inspect) Feb 9, 2025 5:48pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant