Skip to content
This repository has been archived by the owner on Jul 31, 2021. It is now read-only.

fix string error #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ugurdonmez
Copy link

When we select WBNB in To form of exchange, submit button shows 'Insufficient ETH Balance'

@netlify
Copy link

netlify bot commented Jan 20, 2021

👷 Deploy request for swap-master pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: c2e3cb5

Copy link
Contributor

@Chef-Chungus Chef-Chungus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may cause secondary issues.

You can see in this recording that the behaviour is normal for BNB -> other coin pair.

When swapping from BNB to WBNB, the logic appears to be different.

Screen.Recording.2021-01-20.at.20.00.36.mov

@memoyil
Copy link
Contributor

memoyil commented Feb 17, 2021

But what about the translations?

@monmailprovisoire
Copy link

hello i got the following error message can someone help me pls ..Regards

Failed to compile
C:/Users/user/Desktop/pancake-swap-interface-v1/src/connectors/NetworkConnector.ts
TypeScript error in C:/Users/user/Desktop/pancake-swap-interface-v1/src/connectors/NetworkConnector.ts(100,22):
This condition will always return true since this function is always defined. Did you mean to call it instead? TS2774

 98 |         request: { method },
 99 |       } = byKey[result.id]

100 | if (resolve && reject) {
| ^
101 | if ('error' in result) {
102 | reject(new RequestError(result?.error?.message, result?.error?.code, result?.error?.data))
103 | } else if ('result' in result) {

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants