remove several internal-only methods from offsets.pyi #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
cln-offsets-pyi
branch
from
c7b6cbb to
ca32d1f
Compare
MarcoGorelli
commented
Mar 12, 2025
Comment on lines
-126
to
-129
| class BusinessMixin(SingleConstructorOffset): | ||
| def __init__( | ||
| self, n: int = ..., normalize: bool = ..., offset: timedelta = ... | ||
| ) -> None: ... |
There was a problem hiding this comment.
this was only subclassed by BusinessHour and _CustomBusinessMonth, but they both override its only method (__init__). Given that it's not even public, OK to just remove it?
MarcoGorelli
commented
Mar 12, 2025
Comment on lines
-278
to
-283
| def roll_qtrday( | ||
| other: datetime, n: int, month: int, day_opt: str, modby: int | ||
| ) -> int: ... | ||
| def shift_months( | ||
| dtindex: npt.NDArray[np.int64], months: int, day_opt: str | None = ... | ||
| ) -> npt.NDArray[np.int64]: ... |
MarcoGorelli
commented
Mar 12, 2025
| @@ -96,9 +92,6 @@ class BaseOffset: | |||
| def __getstate__(self): ... | |||
| @property | |||
| def nanos(self) -> int: ... | |||
| def onOffset(self, dt: datetime) -> bool: ... | |||
| def isAnchored(self) -> bool: ... | |||
| def is_anchored(self) -> bool: ... | |||
MarcoGorelli
commented
Mar 12, 2025
Comment on lines
-99
to
-100
| def onOffset(self, dt: datetime) -> bool: ... | ||
| def isAnchored(self) -> bool: ... |
There was a problem hiding this comment.
remove quite a while ago
MarcoGorelli
commented
Mar 12, 2025
| @@ -26,10 +26,6 @@ from pandas.tseries.holiday import AbstractHolidayCalendar | |||
| _DatetimeT = TypeVar("_DatetimeT", bound=datetime) | |||
| _TimedeltaT = TypeVar("_TimedeltaT", bound=timedelta) | |||
|
|
|||
| prefix_mapping: dict[str, type] | |||
MarcoGorelli
force-pushed
the
cln-offsets-pyi
branch
from
ca32d1f to
fb18255
Compare
Dr-Irv
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value