GH828 Replace Iterable with Axes for Index.__new__/Index.__init__ #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Apr 26, 2025
tests/test_indexes.py
Outdated
Comment on lines
1328
to
1332
| pd.DatetimeIndex( | ||
| { # type: ignore[arg-type] | ||
| "Jan. 1, 2008": "New Year’s Day" # pyright: ignore[reportArgumentType] | ||
| } | ||
| ) |
Collaborator
There was a problem hiding this comment.
This should work and passing a dict should be acceptable. You have to look at the subclasses of Index (like DatetimeIndex) and modify the __init__() or __new__() methods in those subclasses to accept Axes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value