WIP: Use default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]
#1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
typevar-default
branch
3 times, most recently
from
1a6dbd7 to
f63956a
Compare
MarcoGorelli
changed the title
default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]
|
I'm fine with this. Need to run |
|
cool, thanks! there's a couple of test failures I haven't figured out, will investigate |
MarcoGorelli
force-pushed
the
typevar-default
branch
from
b0d5713 to
e67aaa9
Compare
Dr-Irv
reviewed
May 29, 2025
| @@ -168,7 +168,7 @@ class SeriesGroupBy(GroupBy[Series[S1]], Generic[S1, ByT]): | |||
| self, | |||
| ) -> Iterator[tuple[ByT, Series[S1]]]: ... | |||
|
|
|||
| _TT = TypeVar("_TT", bound=Literal[True, False]) | |||
| _TT = TypeVar("_TT", bound=Literal[True, False], default=Literal[True]) | |||
There was a problem hiding this comment.
I'm a bit surprised that you didn't have to change the import of TypeVar to come from typing_extensions here since you are using the default feature.
|
i think there might be an issue with mypy here, have reported python/mypy#19182 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bit of an experiment
closes #1133
I saw that NumPy follow this pattern, for example here:
https://github.com/numpy/numpy/blob/3363b38d99f87601869c2c9d68c2b16e54509675/numpy/__init__.pyi#L788-L792
and they import
TypeVarfromtyping_extensions(which is a dependency of mypy anyway)This would close 1133 for free, and I think improve ergonomics