Skip to content

BUG: Fix Python2 long unsupport in _can_hold_element #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Licht-T
Copy link
Contributor

@Licht-T Licht-T commented Nov 21, 2017

@Licht-T
Copy link
Contributor Author

Licht-T commented Nov 21, 2017

Where should I add _can_hold_element tests?

@jreback
Copy link
Contributor

jreback commented Nov 21, 2017

i think #18385 also looking at this issue

@codecov
Copy link

codecov bot commented Nov 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8512cc5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18399   +/-   ##
=========================================
  Coverage          ?   91.34%           
=========================================
  Files             ?      164           
  Lines             ?    49730           
  Branches          ?        0           
=========================================
  Hits              ?    45426           
  Misses            ?     4304           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.14% <100%> (?)
#single 39.62% <66.66%> (?)
Impacted Files Coverage Δ
pandas/core/internals.py 94.47% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8512cc5...703e77e. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8512cc5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18399   +/-   ##
=========================================
  Coverage          ?   91.34%           
=========================================
  Files             ?      164           
  Lines             ?    49730           
  Branches          ?        0           
=========================================
  Hits              ?    45426           
  Misses            ?     4304           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.14% <100%> (?)
#single 39.62% <66.66%> (?)
Impacted Files Coverage Δ
pandas/core/internals.py 94.47% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8512cc5...703e77e. Read the comment docs.

@Licht-T
Copy link
Contributor Author

Licht-T commented Nov 21, 2017

@jreback Oops! I'll close this issue!

@Licht-T Licht-T closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecursionError when passing long to fillna
2 participants