Skip to content

implement ensure_localized in datetimelikeArrayMixin #24378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

jbrockmendel
Copy link
Member

This method is used by TimelikeOps._round, so needs to be implemented on the array mixin before we can move forward on #24064.

@TomAugspurger this places the method in a different location than you did in #24024 and made a small docstring edit, but otherwise should be compatible.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #24378 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24378      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51841    51849       +8     
==========================================
+ Hits        47847    47855       +8     
  Misses       3994     3994
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.97% <7.14%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 96.51% <100%> (+0.06%) ⬆️
pandas/core/indexes/datetimelike.py 97.28% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d134ec...4bd6964. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #24378 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24378      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51841    51849       +8     
==========================================
+ Hits        47847    47855       +8     
  Misses       3994     3994
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.97% <7.14%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 96.51% <100%> (+0.06%) ⬆️
pandas/core/indexes/datetimelike.py 97.28% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d134ec...4bd6964. Read the comment docs.

@jreback jreback added the Clean label Dec 21, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 21, 2018
@jreback jreback added the Datetime Datetime data dtype label Dec 21, 2018
@jreback jreback merged commit a70694e into pandas-dev:master Dec 21, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel jbrockmendel deleted the ensure branch April 5, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants