Skip to content

Conversation

@vaibhavhrt
Copy link
Contributor

@vaibhavhrt vaibhavhrt commented May 13, 2019

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #26371 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26371      +/-   ##
==========================================
- Coverage   91.68%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50700    50701       +1     
==========================================
- Hits        46486    46483       -3     
- Misses       4214     4218       +4
Flag Coverage Δ
#multiple 90.18% <100%> (ø) ⬆️
#single 41.17% <100%> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.72% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48d1ff...4933ba8. Read the comment docs.

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #26371 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26371      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.01%     
==========================================
  Files         174      174              
  Lines       50703    50704       +1     
==========================================
- Hits        46488    46484       -4     
- Misses       4215     4220       +5
Flag Coverage Δ
#multiple 90.18% <100%> (ø) ⬆️
#single 41.18% <100%> (-0.17%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.72% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.6% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e43a4...64ded46. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented May 13, 2019

Looks like an isort error - can you fix up and merge master?

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label May 13, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone May 13, 2019
@vaibhavhrt
Copy link
Contributor Author

There is an isort error in a file that I haven't even touched. Merging upstream/master should fix it.

@WillAyd WillAyd merged commit 2123a96 into pandas-dev:master May 13, 2019
@WillAyd
Copy link
Member

WillAyd commented May 13, 2019

Nice work @vaibhavhrt

@vaibhavhrt
Copy link
Contributor Author

@WillAyd thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix type annotations for pandas.core.indexes.base

2 participants