Skip to content

Renaming asv setting build_cache_size #26703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Renaming asv setting build_cache_size #26703

merged 1 commit into from
Jun 10, 2019

Conversation

datapythonista
Copy link
Member

The CI job that is checking that the benchmarks don't break is reporting that an asv setting has been renamed.

I think we've got a server where we run the benchmarks, not sure if we replicate the environment there at every run from environment.yml. Otherwise I guess we should do it manually before merging this.

@TomAugspurger I think you manage that server? does this make sense?

@datapythonista datapythonista added Performance Memory or execution speed performance CI Continuous Integration labels Jun 7, 2019
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #26703 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26703      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50701    50701              
==========================================
- Hits        46588    46584       -4     
- Misses       4113     4117       +4
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.93% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649ad5c...6c299bf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #26703 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26703      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50701    50701              
==========================================
- Hits        46588    46584       -4     
- Misses       4113     4117       +4
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.93% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649ad5c...6c299bf. Read the comment docs.

@TomAugspurger
Copy link
Contributor

I think we've got a server where we run the benchmarks, not sure if we replicate the environment there at every run from environment.yml

I don't think so. I think ASV has it's own way of building the environment from the matrix of dependencies.

@datapythonista
Copy link
Member Author

Looks like the benchmarks are failing, the error here is unrelated to this PR, I also saw the same error in #26414. We don't see in other PRs, because we only check the benchmarks when something inside asv_bench is modified, and I guess the failure was produced by changes in pandas.

Will check which change broke it, and open an issue.

@jreback
Copy link
Contributor

jreback commented Jun 8, 2019

@datapythonista is this still needed?

@datapythonista
Copy link
Member Author

@jreback my understanding is that a future version of asv will remove the renamed setting, and I don't know if our benchmarks will break or the current setting will be ignored, but I think we should make this change before that.

@jreback jreback added this to the 0.25.0 milestone Jun 10, 2019
@jreback jreback merged commit 13023c6 into pandas-dev:master Jun 10, 2019
@jreback
Copy link
Contributor

jreback commented Jun 10, 2019

thanks @datapythonista

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants