-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Renaming asv setting build_cache_size #26703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26703 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 174 174
Lines 50701 50701
==========================================
- Hits 46588 46584 -4
- Misses 4113 4117 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26703 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 174 174
Lines 50701 50701
==========================================
- Hits 46588 46584 -4
- Misses 4113 4117 +4
Continue to review full report at Codecov.
|
I don't think so. I think ASV has it's own way of building the environment from the matrix of dependencies. |
Looks like the benchmarks are failing, the error here is unrelated to this PR, I also saw the same error in #26414. We don't see in other PRs, because we only check the benchmarks when something inside Will check which change broke it, and open an issue. |
@datapythonista is this still needed? |
@jreback my understanding is that a future version of asv will remove the renamed setting, and I don't know if our benchmarks will break or the current setting will be ignored, but I think we should make this change before that. |
thanks @datapythonista |
The CI job that is checking that the benchmarks don't break is reporting that an
asv
setting has been renamed.I think we've got a server where we run the benchmarks, not sure if we replicate the environment there at every run from
environment.yml
. Otherwise I guess we should do it manually before merging this.@TomAugspurger I think you manage that server? does this make sense?