Skip to content

ENH: treat list of namedtuples like list of dict in DataFrame() #27494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

ENH: treat list of namedtuples like list of dict in DataFrame() #27494

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2019

Following discussion in #27309 about unifying "list of records" behavior across the board.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a glance looks ok, ideally can simplify some of the cython code (and add comments) as somewhat hard to follow

@jreback jreback added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Jul 25, 2019
pilkibun added 4 commits July 25, 2019 18:23
* origin/master: (52 commits)
  CLN: Prune unnecessary indexing code (#27576)
  CLN: get parts of Block.replace out of try/except (#27408)
  Groupby transform cleanups (#27467)
  TYPING: add type hints to pandas\io\formats\printing.py (#27579)
  TYPING: Partial typing of Categorical (#27318)
  REF: collect indexing methods (#27588)
  API: Add entrypoint for plotting (#27488)
  REF: implement module for shared constructor functions (#27551)
  CLN: more assorted cleanups (#27555)
  CLN: pandas\io\formats\format.py (#27577)
  TYPING: some type hints for core.dtypes.common (#27564)
  DEPR: remove .ix from tests/indexing/multiindex/test_ix.py (#27565)
  DEPR: remove .ix from tests/indexing/test_partial.py (#27566)
  TST: add regression test for slicing IntervalIndex MI level with scalars (#27572)
  DEPR: remove .ix from tests/indexing/multiindex/test_setitem.py (#27574)
  BUG: display.precision of negative complex numbers (#27511)
  Removed ABCs from pandas._typing (#27424)
  DEPR: remove .ix from tests/indexing/test_indexing.py (#27535)
  BUG: fix+test quantile with empty DataFrame, closes #23925 (#27436)
  BUG: maybe_convert_objects mixed datetimes and timedeltas  (#27438)
  ...
@ghost
Copy link
Author

ghost commented Jul 25, 2019

pushed fixed for all the reviews, and I'll work on making this more readable in the next few days.
Also, need to very the final performance impact, I'm not sure the ones quoted in the docs are still accurate (should be better).

@ghost
Copy link
Author

ghost commented Jul 31, 2019

II wanted to take care of this in thanks to @jorisvandenbossche for helping with the previous PR, but I just don't want to go through another pandas code review experience. I'm sorry, Joris.

@ghost ghost closed this Jul 31, 2019
@ghost ghost deleted the list_of_namedtuples3 branch July 31, 2019 14:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG?: namedtuples fields not checked on DataFrame constructor
1 participant