Skip to content

TST: concat(..., copy=False) with datetime tz-aware data raises ValueError: cannot create a DatetimeTZBlock without a tz #33458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 13, 2020
Merged

TST: concat(..., copy=False) with datetime tz-aware data raises ValueError: cannot create a DatetimeTZBlock without a tz #33458

Changes from 8 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
215a049
Added in a regression test for issue #25257. Verified that it fails o…
SurajH1 Apr 10, 2020
a8748aa
style changes
SurajH1 Apr 10, 2020
93be1c4
Added in assert statement
SurajH1 Apr 10, 2020
a0caac6
indentation fixes
SurajH1 Apr 10, 2020
9f37013
Whitespace fixes
SurajH1 Apr 10, 2020
d0ce00e
indentation fixes
SurajH1 Apr 10, 2020
6e33152
fixed spacing
SurajH1 Apr 10, 2020
ce8fa9c
Indentation fixes
SurajH1 Apr 10, 2020
de1373e
Paramterized Copy-False
SurajH1 Apr 13, 2020
a0c4e2b
reformatted test_concat.py
SurajH1 Apr 17, 2020
f095a74
Made some changes to visit_call. I know its wrong but adding this com…
SurajH1 Apr 17, 2020
ba4e823
Fixed the bug. Realized that we had to parse and evaluate the inner e…
SurajH1 Apr 17, 2020
0291828
Revert "Made some changes to visit_call. I know its wrong but adding …
SurajH1 Apr 17, 2020
f63c5bd
Revert "reformatted test_concat.py"
SurajH1 Apr 17, 2020
af1ea2a
Revert "Paramterized Copy-False"
SurajH1 Apr 17, 2020
85dd861
Revert "Indentation fixes"
SurajH1 Apr 17, 2020
dd6e292
Merge branch 'new_master'
SurajH1 Apr 17, 2020
243d650
Fixed the bug
SurajH1 Apr 17, 2020
cff2f7d
added in whitespace after ','
SurajH1 Apr 20, 2020
11e1710
Merge branch 'master' of https://github.com/SurajH1/pandas
SurajH1 Apr 20, 2020
9a799b8
reverse changes
SurajH1 May 16, 2020
f757af8
Merge remote-tracking branch 'upstream/master' into SurajH1-master
simonjayhawkins Jul 12, 2020
6699cf8
remove unrelated changes
simonjayhawkins Jul 12, 2020
95d551f
parametrize on copy
simonjayhawkins Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pandas/tests/dtypes/test_concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,13 @@ def test_concat_mismatched_categoricals_with_empty():
result = _concat.concat_compat([ser1._values, ser2._values])
expected = pd.concat([ser1, ser2])._values
tm.assert_categorical_equal(result, expected)


def test_no_tz_concat_without_copy():
# This will raise a ValueError issue if it fails
# Regression test for issue 25257
df = pd.DataFrame({'timestamp': [pd.Timestamp('2020-04-08 09:00:00.709949+0000',
tz='UTC')], })
result = pd.concat([df], copy=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you parameterize on copy=[True, False]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you push up the change

expected = df
tm.assert_frame_equal(result, expected)