Ensure file is closed promptly in case of error #35567
Conversation
|
can you add a test |
|
Very difficult to add a test since the failure is during the constructor meaning that we have no references to the failed state. |
| raise ValueError("unknown SAS format") | ||
|
|
||
| if iterator or chunksize: | ||
| return reader |
There was a problem hiding this comment.
The problem is potentialy here also, e.g. if the user forgets to wrap his own code in a try/finally.
Could it be an idea to add __enter__ & __exit__ to ReaderBase and rearrange to use with blocks, both here and below?
There was a problem hiding this comment.
What the user does with the Reader object is not pandas' concern ;)
The important thing is not to leave any created objects in an inconsistent state.
|
A dependency on external libs for this is not great IMO. Are there tests for closed files for other file formats, e.g. excel or csv files? Could you try to emulate them? |
|
OK, let's follow up in the new PR #35587 (sorry, I deleted my repo in the meantime, so need a new PR). |
4 participants
Fixes #35566