Skip to content

BLD: bump xlrd min version to 1.2.0 #35728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

jbrockmendel
Copy link
Member

Warnings about time.clock are filling up the py37 min_version build. xlrd 1.2.0 was released Dec 15, 2018, so I think we're safe to bump it.

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 14, 2020
@simonjayhawkins simonjayhawkins added the IO Excel read_excel, to_excel label Aug 14, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 6325a33 into pandas-dev:master Aug 14, 2020
@jreback
Copy link
Contributor

jreback commented Aug 14, 2020

not sure if there is an open issue about this?

@jbrockmendel jbrockmendel deleted the ci-warnless branch August 14, 2020 21:38
@simonjayhawkins
Copy link
Member

not sure if there is an open issue about this?

doesn't look like it. ignore_xlrd_time_clock_warning added in #23727 see also #23727 (comment)

jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants