-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fix pd.json_normalize to not skip the first element of a generator input #38698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
898ccdf
BUG: Fix pd.json_normalize to not skip the first element of a generat…
avinashpancham 66f5ba6
Merge remote-tracking branch 'upstream/master' into GH35923
avinashpancham 8537705
Address comments
avinashpancham e885c86
Merge remote-tracking branch 'upstream/master' into GH35923
avinashpancham 89546ab
Address comments
avinashpancham bf25860
Remove whitespace
avinashpancham 9f1f2f9
Raise NotImplementedError for an input that is not an Iterable
avinashpancham 775f80e
Rename test name
avinashpancham f9e5332
Merge remote-tracking branch 'upstream/master' into GH35923
avinashpancham cc9cfae
Merge remote-tracking branch 'upstream/master' into GH35923
avinashpancham 2ca6be7
Merge remote-tracking branch 'upstream/master' into GH35923
avinashpancham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could have some big performance implications when dealing with large generators - is it not alternately possible to just store the first element for inspection and reuse as necessary while maintaining the state of the generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we barely support generators (its not even documented), so -1 if this adds any complexity.