Skip to content

TST: Remove duplicate invalid sheet tests from io.excel #39589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2021
Merged

TST: Remove duplicate invalid sheet tests from io.excel #39589

merged 1 commit into from
Feb 4, 2021

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

Followup from #39482 - removed tests are duplicates of test_readers.test_bad_sheetname_raises

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel labels Feb 4, 2021
@jreback jreback added this to the 1.3 milestone Feb 4, 2021
@jreback jreback merged commit 5e8fabb into pandas-dev:master Feb 4, 2021
@jreback
Copy link
Contributor

jreback commented Feb 4, 2021

thanks @rhshadrach

@rhshadrach rhshadrach deleted the dedup_excel_tests branch February 4, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @jreback