Skip to content

DEP: bump min version of openpyxl to 3.0.0 #39603 #39702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 15, 2021
Merged

DEP: bump min version of openpyxl to 3.0.0 #39603 #39702

merged 10 commits into from
Feb 15, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Feb 9, 2021 •
edited
Loading

@fangchenli fangchenli added Dependencies Required and optional dependencies IO Excel read_excel, to_excel labels Feb 9, 2021
@jreback
Copy link
Contributor

jreback commented Feb 9, 2021

cc @rhshadrach

rhshadrach
rhshadrach requested changes Feb 9, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some version checks in the openpyxl tests that can be removed/simplified.

rhshadrach
rhshadrach requested changes Feb 11, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request, rest look great!

rhshadrach
rhshadrach approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @fangchenli

@jreback jreback added this to the 1.3 milestone Feb 15, 2021
@jreback jreback merged commit d5d43e0 into pandas-dev:master Feb 15, 2021
@jreback
Copy link
Contributor

jreback commented Feb 15, 2021

thanks @fangchenli

znicholls pushed a commit to znicholls/pandas that referenced this pull request Feb 17, 2021
@fangchenli @znicholls
DEP: bump min version of openpyxl to 3.0.0 pandas-dev#39603 (pandas-d…
fd1c797 
…ev#39702)
@fangchenli fangchenli deleted the bump-openpyxl branch March 18, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies IO Excel read_excel, to_excel
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

DEP: Bump minimum version of openpyxl to 3.0.0
3 participants
@fangchenli @jreback @rhshadrach