REF: extract_array earlier in block construction #40026
Merged
+43
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it is mainly |
jreback
reviewed
Feb 25, 2021
| @@ -1638,16 +1640,20 @@ def create_block_manager_from_blocks(blocks, axes: List[Index]) -> BlockManager: | |||
| raise construction_error(tot_items, blocks[0].shape[1:], axes, e) | |||
|
|
|||
|
|
|||
| # We define this here so we can override it in tests.extension.test_numpy | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to eventually get the extract_array out of maybe_coerce_values which will improve
Block.__init__perf.The main remaining blocker to that is downstream usage. @jorisvandenbossche i know pyarrow accesses some of core.internals, do you know if it is just
make_blockor is anything else accessed?