Skip to content

CI: increase codecov target - append ArrayManager tests coverage #40711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2021
Merged

CI: increase codecov target - append ArrayManager tests coverage #40711

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
041a49a
CI: increase codecov target - append ArrayManager tests coverage
jorisvandenbossche Mar 31, 2021
dc42898
Merge remote-tracking branch 'upstream/master' into co-codecov
jorisvandenbossche Apr 2, 2021
10f4296
always cov-append
jorisvandenbossche Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ci/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ fi
echo $PYTEST_CMD
sh -c "$PYTEST_CMD"

if [ "$COVERAGE" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already above: https://github.com/pandas-dev/pandas/pull/40711/files#diff-fad2fa83c042cce646b2c1a0455e9b60c22dd5f105ed8859ce85dcf361c07fbdL12

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this one is different.

Now, maybe it can't hurt to add the --cov-append in all cases, though (so also for the first invocation)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but let's try to have a single invocation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to have a single invocation

There are two invocations, that's the point of also testing the ArrayManager

COVERAGE="-s --cov=pandas --cov-report=xml --cov-append"
fi


PYTEST_AM_CMD="PANDAS_DATA_MANAGER=array pytest -m \"$PATTERN and arraymanager\" -n $PYTEST_WORKERS --dist=loadfile -s --strict-markers --durations=30 --junitxml=test-data.xml $TEST_ARGS $COVERAGE pandas"

echo $PYTEST_AM_CMD
Expand Down
2 changes: 1 addition & 1 deletion codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ coverage:
status:
project:
default:
target: '72'
target: '82'
patch:
default:
target: '50'
Expand Down