CLN/TST: address/annotate TODOs #44154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 23, 2021
| @@ -1086,7 +1086,7 @@ cdef void rank_sorted_1d( | |||
| # array that we sorted previously, which gives us the location of | |||
| # that sorted value for retrieval back from the original | |||
| # values / masked_vals arrays | |||
| # TODO: de-duplicate once cython supports conditional nogil | |||
| # TODO(cython3): de-duplicate once cython supports conditional nogil | |||
There was a problem hiding this comment.
Probably good to reference in #34213 that these TODO styles can be addressed (or vice versa)?
mroeschke
reviewed
Oct 23, 2021
| @@ -136,7 +136,7 @@ def __init__( | |||
| self.window = window | |||
| self.min_periods = min_periods | |||
| self.center = center | |||
| # TODO: Change this back to self.win_type once deprecation is enforced | |||
| # TODO(2.0): Change this back to self.win_type once deprecation is enforced | |||
There was a problem hiding this comment.
Similarly, good to attach this TODO style to an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.