Skip to content

REF: remove always-True DataFrame._iset_item kwarg #44587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel
Copy link
Member Author

@jorisvandenbossche any idea why this would be failing on the AM build? my only guess is that yesterday's change from skipping to xfailing is interacting with the weird statefullness of the tests in test_expressions

@jorisvandenbossche
Copy link
Member

I have seen that before the last days (maybe in that PR, not fully sure, the tests were passing in the last commit there), but always only appeared from time to time (restarting might "solve" it), and I am not able to reproduce it locally.

change from skipping to xfailing is interacting with the weird statefullness of the tests in test_expressions

The test_expressions.py itself is not using any skip/xfails, so I have a hard time understanding how that would be related.

Looking at the failures, I think all have to do with for some reason not actually using numexpr, when the test is thought to be using it. Will have a check if any of the tests we currently skip->xfail might meddle with those settings.

@jbrockmendel
Copy link
Member Author

I have seen that before the last days

that's pretty strong evidence that the skip->xfail change is unrelated. thanks for taking a look.

@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Nov 25, 2021
@jreback jreback added this to the 1.4 milestone Nov 25, 2021
@jreback jreback merged commit 2b53ea8 into pandas-dev:master Nov 25, 2021
@jbrockmendel jbrockmendel deleted the ref-iset_item branch November 25, 2021 18:08
@jorisvandenbossche
Copy link
Member

I have seen that before the last days

that's pretty strong evidence that the skip->xfail change is unrelated. thanks for taking a look.

In the end it was related, but not to any ArrayManager stuff in that PR, but by enabling a dask test (which we don't run anywhere else), which changes the use_numexpr setting ... and our tests are not robust against that changed setting ... -> #44601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants