Skip to content

BLD: drop options.package_data from setup.cfg #46271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2022
Merged

BLD: drop options.package_data from setup.cfg #46271

merged 2 commits into from
Apr 10, 2022

Conversation

NickCrews
Copy link
Contributor

@NickCrews NickCrews commented Mar 8, 2022 •
edited
Loading

@fangchenli it looks like you have a lot of history here

@fangchenli
Copy link
Member

I think you need to trigger the sdist build.

@lithomas1

@fangchenli fangchenli added the Build Library building on various platforms label Mar 8, 2022
@NickCrews
Copy link
Contributor Author

NickCrews commented Mar 8, 2022 •
edited
Loading

I think you need to trigger the sdist build.

It looks like the sdist build ran? https://github.com/pandas-dev/pandas/runs/5470020092?check_suite_focus=true#step:5:856. There you can see that the pandas/io/formats/templates/*.tpl files are all included. Not sure about the .dll files, maybe that's what you mean, the windows sdist build needs to get run?

The test failures are unrelated, due to #46274

NickCrews added a commit to NickCrews/pandas that referenced this pull request Mar 8, 2022
@NickCrews
BLD: Upload sdist artifact from CI
6697f2d 
Now it is possible to inspect the sdist that is built, to
see what was included and
for debugging.

Inspired by needing to see what was acutally included in the sdist at
pandas-dev#46271
@NickCrews NickCrews mentioned this pull request Mar 8, 2022
Merged
4 tasks
@NickCrews
Copy link
Contributor Author

If we wait for #46277 to land then we can manually inspect that this PR does not affect the sdists (at least the linux build on CI)

mroeschke pushed a commit that referenced this pull request Mar 11, 2022
@NickCrews
BLD: Upload sdist artifact from CI (#46277)
17dda44 
* BLD: Upload sdist artifact from CI

Now it is possible to inspect the sdist that is built, to
see what was included and
for debugging.

Inspired by needing to see what was acutally included in the sdist at
#46271

* BLD: fix artifact name

Got this error before:
Error: Artifact name is not valid:
refs/pull/46277/merge-3.8-sdist.gz.
Contains the following character:  Forward slash /

This is more precise anyways.

* BLD: Drop SHA from sdist artifact name

Per
#46277 (comment)
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Mar 30, 2022
@NickCrews @simonjayhawkins
BLD: Upload sdist artifact from CI (pandas-dev#46277)
26d88ca 
* BLD: Upload sdist artifact from CI

Now it is possible to inspect the sdist that is built, to
see what was included and
for debugging.

Inspired by needing to see what was acutally included in the sdist at
pandas-dev#46271

* BLD: fix artifact name

Got this error before:
Error: Artifact name is not valid:
refs/pull/46277/merge-3.8-sdist.gz.
Contains the following character:  Forward slash /

This is more precise anyways.

* BLD: Drop SHA from sdist artifact name

Per
pandas-dev#46277 (comment)
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Apr 8, 2022
NickCrews added 2 commits April 8, 2022 18:46
@NickCrews
BLD: Clean up MANIFEST.in
84ca14c 
Add a note about why we
```
graft pandas/_libs/src
graft pandas/_libs/tslibs/src
```
per https://github.com/pandas-dev/pandas/pull/41977/files#r650501025

Move versioneer.py up to the top with the
"top-level" stuff.

Delete a few redundant includes that
are already included from the `graft pandas`
and not excluded anywhere else.
@NickCrews
BLD: drop options.package_data from setup.cfg
a009466 
These two glob patterns are already covered because:
- They are listed in MANIFEST.in
AND
- include_package_data is set to True

See pandas-dev#46270
@NickCrews NickCrews force-pushed the package-data-tweaks branch from ca5320a to a009466 Compare April 9, 2022 00:46
@NickCrews
Copy link
Contributor Author

OK, so I downloaded the python 3.9 sdist artifacts from the last successful run before this PR (https://github.com/pandas-dev/pandas/actions/runs/2118052199) and from this PR (https://github.com/pandas-dev/pandas/actions/runs/2138906174)

and ran diff -rq pandas-1.5.0.dev0+660.gb3b5e2a46a pandas-1.5.0.dev0+663.g468ff52b7b and got:

Files pandas-1.5.0.dev0+660.gb3b5e2a46a/MANIFEST.in and pandas-1.5.0.dev0+663.g468ff52b7b/MANIFEST.in differ
Files pandas-1.5.0.dev0+660.gb3b5e2a46a/PKG-INFO and pandas-1.5.0.dev0+663.g468ff52b7b/PKG-INFO differ
Files pandas-1.5.0.dev0+660.gb3b5e2a46a/pandas/_version.py and pandas-1.5.0.dev0+663.g468ff52b7b/pandas/_version.py differ
Files pandas-1.5.0.dev0+660.gb3b5e2a46a/pandas.egg-info/PKG-INFO and pandas-1.5.0.dev0+663.g468ff52b7b/pandas.egg-info/PKG-INFO differ
Files pandas-1.5.0.dev0+660.gb3b5e2a46a/setup.cfg and pandas-1.5.0.dev0+663.g468ff52b7b/setup.cfg differ

I checked each of these and they look as expected.

So I think that this doesn't introduce any other changes? @fangchenli any other things to check, or is this good to merge? Thanks!

@fangchenli fangchenli removed the Stale label Apr 9, 2022
@jreback jreback added this to the 1.5 milestone Apr 10, 2022
@jreback jreback merged commit 96ecaf9 into pandas-dev:main Apr 10, 2022
@jreback
Copy link
Contributor

jreback commented Apr 10, 2022

thanks @NickCrews

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@NickCrews @yehoshuadimarsky
BLD: Upload sdist artifact from CI (pandas-dev#46277)
6a93d8f 
* BLD: Upload sdist artifact from CI

Now it is possible to inspect the sdist that is built, to
see what was included and
for debugging.

Inspired by needing to see what was acutally included in the sdist at
pandas-dev#46271

* BLD: fix artifact name

Got this error before:
Error: Artifact name is not valid:
refs/pull/46277/merge-3.8-sdist.gz.
Contains the following character:  Forward slash /

This is more precise anyways.

* BLD: Drop SHA from sdist artifact name

Per
pandas-dev#46277 (comment)
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@NickCrews @yehoshuadimarsky
BLD: drop options.package_data from setup.cfg (pandas-dev#46271)
bc2883e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangchenli fangchenli fangchenli approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BLD: Remove options.package_data from setup.cfg
3 participants
@NickCrews @fangchenli @jreback