ENH: Support mask for groupby var and mean #48078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
commented
Aug 14, 2022
| is_datetimelike=is_datetimelike, | ||
| ) | ||
| elif self.how == "var": | ||
| func( |
Member
Author
There was a problem hiding this comment.
This part needs some refactoring when every algo supports masks
…r_mean # Conflicts: # pandas/core/groupby/ops.py
mroeschke
added
Groupby
NA - MaskedArrays
…r_mean # Conflicts: # pandas/core/groupby/ops.py
…r_mean # Conflicts: # pandas/core/groupby/ops.py
rhshadrach
approved these changes
Aug 30, 2022
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
lgtm; one optional recommendation
Member
Author
|
Thx for review @rhshadrach |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This saves around 30-35% in the aggregation operation for nullable dtypes with 1/3 missing values compared to the previous implementation
cc @jorisvandenbossche