ENH: Add use nullable dtypes to read_excel #49091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Enhancement
IO Excel
# Conflicts: # doc/source/whatsnew/v2.0.0.rst # pandas/io/excel/_base.py # pandas/tests/io/excel/test_readers.py # pandas/tests/io/excel/test_writers.py
|
This is ready now |
rhshadrach
requested changes
Oct 24, 2022
pandas/io/excel/_base.py
Outdated
| @@ -271,6 +271,13 @@ | |||
|
|
|||
| .. versionadded:: 1.2.0 | |||
|
|
|||
| use_nullable_dtypes : bool = False | |||
There was a problem hiding this comment.
: bool, default False here I think.
| with tm.ensure_clean(read_ext) as file_path: | ||
| df.to_excel(file_path, "test", index=False) | ||
| result = pd.read_excel( | ||
| file_path, sheet_name="test", use_nullable_dtypes=True, dtype="float64" |
There was a problem hiding this comment.
Makes sense to me that dtype overrides use_nullable_dtypes - could you add this to the docstring.
|
Thanks @phofl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This sits on top of #49089.
Would prefer round tripping during testing instead of adding those files to the repository