Skip to content

BUG: Fixes Incompatible return value type in pandas/core/generic.py #52897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 7, 2023

Conversation

bunardsheng
Copy link
Contributor

@bunardsheng bunardsheng commented Apr 24, 2023

@rhshadrach rhshadrach added Dtype Conversions Unexpected or buggy dtype conversions Bug labels Apr 25, 2023
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While subtle, this changes from a NumPy int to a Python int. I think this should be noted in the whatsnew as a bugfix.

Are the changes to pandas_web intentional?

@bunardsheng
Copy link
Contributor Author

While subtle, this changes from a NumPy int to a Python int. I think this should be noted in the whatsnew as a bugfix.

Are the changes to pandas_web intentional?

My mistake, I will revert the changes as the changes in web pertain to a separate issue.

@bunardsheng bunardsheng changed the title Fixes Incompatible return value type in pandas/core/generic.py BUG: Fixes Incompatible return value type in pandas/core/generic.py Apr 26, 2023
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of nitpicks and I think this should get an entry in the whatsnew for 2.1.0

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great - I think it just needs a note in the whatsnew under Bug fixes in the Numeric section.

@bunardsheng
Copy link
Contributor Author

All looks great - I think it just needs a note in the whatsnew under Bug fixes in the Numeric section.

The entry has been added to the whatsnew.

Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change :)

Even though it is a small change it might break code for people who explicitly converted it to int using Series.size.item(). I hope this doesn't require a deprecation cycle @jbrockmendel

@jbrockmendel
Copy link
Member

No objections here

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 2.1 milestone May 6, 2023
@rhshadrach
Copy link
Member

@bunardsheng - conflict needs to be resolved and we're good to go.

@bunardsheng
Copy link
Contributor Author

@bunardsheng - conflict needs to be resolved and we're good to go.

All conflicts should be resolved. Can this PR be merged now, and should I close the PR?

@rhshadrach rhshadrach merged commit 956b800 into pandas-dev:main May 7, 2023
@rhshadrach
Copy link
Member

Thanks @bunardsheng!

@bunardsheng bunardsheng deleted the generic-expected-int branch May 7, 2023 15:31
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants