Skip to content

Conversation

@ggold7046
Copy link
Contributor

@ggold7046 ggold7046 commented Nov 11, 2023

This is a GIthub Action that creates a new issue (and delete the old one) reporting all the errors and label and Docs and Good First Issue for a broken link.

This is a GIthub Action that creates a new issue (and delete the old one) reporting all the errors and label and Docs and Good First Issue for a broken link.
@ggold7046 ggold7046 requested a review from mroeschke as a code owner November 11, 2023 15:21
@ggold7046
Copy link
Contributor Author

ggold7046 commented Nov 11, 2023

Hi @pmeier, how to proceed with the 3rd part ? The 2nd part is merged.

Almost every time the linkcheck file is run there is a new broken link found. Is there a way to automatically append that link into the ignore list ?

pmeier Is there any way to Dm you for the PR? I had tried to tag you in the merged PR , but no luck. Do we get notifications in merged or closed PRs ?

@pmeier
Copy link
Contributor

pmeier commented Nov 16, 2023

Almost every time the linkcheck file is run there is a new broken link found. Is there a way to automatically append that link into the ignore list ?

No, and that is not the point. When this workflow is running on a schedule and finds broken links, a new issue should be created containing all the broken links so a human can come and fix them.

Just adding everything to the ignore list is the opposite of what we want. Ideally, we don't want to have an ignore list at all. This is likely not possible, because some links like we have seen for http:// will never work so they have be ignored. But the ignore list should be as short as possible.

So if you are stuck on this PR, you can also work on reducing the ignore list.

@datapythonista
Copy link
Member

Thanks for the help with this @ggold7046. The issue you are trying to address is not trivial, and the changes in this PR don't seem to be addressing the issue. I would suggest that you work on an issue that you fully understand. I'll close here, feel free to open a PR once you're sure you understand the problem and you have a reasonable solution. Thank you!

@ggold7046 ggold7046 deleted the patch-1 branch November 17, 2023 18:33
@ggold7046
Copy link
Contributor Author

ggold7046 commented Nov 17, 2023

So if you are stuck on this PR, you can also work on reducing the ignore list.

@pmeier, I would like to work on the last part of this from where I started.

  1. If errors are found, have the GIthub Action create a new issue (and delete the old one) reporting all the errors and label and Docs and Good First Issue

I would like to work on this one.

@ggold7046
Copy link
Contributor Author

this PR don't seem to be addressing the issue.

Hi @datapythonista , It was a PR work in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC/CI: Add Github Action cron job to check external links in documentation

3 participants