Skip to content

Remove maybe unused function #57814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2024
Merged

Remove maybe unused function #57814

merged 2 commits into from
Mar 11, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 11, 2024

This is a private function that's only a part of one xfail test. I wonder if it's possible to remove it or not, given that the current minimum required version of matplotlib is already 3.6.3.

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Mar 11, 2024
@mroeschke mroeschke added this to the 3.0 milestone Mar 11, 2024
@mroeschke mroeschke added the Visualization plotting label Mar 11, 2024
mroeschke
mroeschke approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yeah if this is not used anywhere but testing it can be removed

@mroeschke mroeschke merged commit d6c2586 into pandas-dev:main Mar 11, 2024
54 of 55 checks passed
@mroeschke
Copy link
Member

Thanks @tqa236

@tqa236 tqa236 deleted the remove-maybe-unused-function branch March 12, 2024 03:17
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@tqa236 @pmhatre1
Remove maybe unused function (pandas-dev#57814)
a031c7d 
* Remove unused function

* Remove unused function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tqa236 @mroeschke