Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: Bump optional dependencies #60655

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

mroeschke
Copy link
Member

These should have been out for at least ~1 year once pandas 3.0 comes out

@mroeschke mroeschke added the Dependencies Required and optional dependencies label Jan 3, 2025
@mroeschke mroeschke added this to the 3.0 milestone Jan 3, 2025
@WillAyd
Copy link
Member

WillAyd commented Jan 10, 2025

Looks good - maybe worth holding off until after 2.3 gets released?

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Feb 10, 2025
@mroeschke mroeschke removed the Stale label Feb 10, 2025
clipboard = ['PyQt5>=5.15.9', 'qtpy>=2.3.0']
compression = ['zstandard>=0.19.0']
compression = ['zstandard>=0.22.0']
timezone = ['pytz>=2023.4']
all = ['adbc-driver-postgresql>=0.10.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly tangential but the adbc driver libraries are all released at the same time. Not sure how we got a minimum for SQLite of 0.8.0 and postgresql at 0.10.0, but should probably bump the former to match the latter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. I tried at least moving these installs to conda-forge in 39cdaf1 but I was getting some openssl dependency conflicts. I'll try again with bumping these version in the coming weeks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an open issue on windows for using conda-forge, so I'd suggest punting that until fixed upstream. See apache/arrow-adbc#1149

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I see that that the conda forge packages are noarch now so I think they should work on Windows now? https://anaconda.org/conda-forge/adbc-driver-postgresql/files?page=2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps that worked for early versions of arrow-adbc (I see those go up to 0.5.0) but at the moment there is no way for these to be architecture independent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants