Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 60723 resolved #60730

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue 60723 resolved #60730

wants to merge 2 commits into from

Conversation

BAnSsal
Copy link

@BAnSsal BAnSsal commented Jan 18, 2025 •
edited
Loading

Adjusted the condition to set name = 0 only when name is explicitly None.
Previously, the name attribute was being overwritten unconditionally when ignore_index=True, even if a valid name existed.

rhshadrach
rhshadrach requested changes Feb 8, 2025
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. When changing any behavior, please always add tests.

@rhshadrach rhshadrach added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Concatenating dataframe and series with ignore_index = True drops the series name
2 participants
@BAnSsal @rhshadrach