BUG: Ensure to_datetime raises errors for out-of-bounds scalar inputs #60744
Conversation
kosiew
changed the title
pandas/core/tools/datetimes.py
Outdated
| @@ -479,11 +479,20 @@ def _array_strptime_with_fallback( | |||
| return Index(result, dtype=result.dtype, name=name) | |||
|
|
|||
|
|
|||
| def _to_datetime_with_unit(arg, unit, name, utc: bool, errors: str) -> Index: | |||
| def _to_datetime_with_unit(arg, unit, name, utc: bool, errors: str) -> DatetimeIndex: | |||
There was a problem hiding this comment.
Making the annotation -> DatetimeIndex reflects that reality more precisely and helps both developers and tooling (like mypy) be certain of the return type.
There was a problem hiding this comment.
If errors=="ignore" we would get an Index[object] back so this is correct
There was a problem hiding this comment.
Good point. Thanks for pointing this out.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.