-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous updates for Pyodide 0.27: bump WASM CI and revise Arrow compatibility note #60756
Miscellaneous updates for Pyodide 0.27: bump WASM CI and revise Arrow compatibility note #60756
Conversation
4ab6a59
to
66012bb
Compare
66012bb
to
682a867
Compare
2a66586
to
28fe80a
Compare
Could you bump pyodide in for the wheel builds then to match the version in our unit tests? |
I could, but it needs this PR to make it to a release: pypa/cibuildwheel#2117 |
OK no problem. Thanks @agriyakhetarpal |
… compatibility note (pandas-dev#60756) * Update Pyodide versions for CI * Git-ignore Pyodide xbuildenv folder * Pin to Pyodide 0.27.1 * Drop "WASM (pyodide and pyscript)" from Arrow compatibility notes * `TestCoercionFloat32.test_setitem` now xpasses
closes #xxxx (Replace xxxx with the GitHub issue number)Added type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I noticed via #60747 that the Pyodide CI job for
pandas
inunit-tests.yml
is still using a version of Pyodide1 that is quite old by this point; we no longer support it, as we have recently released Pyodide 0.27 this January (https://github.com/pyodide/pyodide/releases/tag/0.27.1). On the other hand,cibuildwheel
inwheels.yml
builds against Pyodide 0.26 at the moment.Other notes around the changes here:
pyodide-build
from the Pyodide runtime/repository, so its version does not stay in sync with the Pyodide runtime version..gitignore
fileTestCoercionFloat32.test_setitem
that now xpasses with Emscripten 3.1.58.Please let me know if you want me to split any of the changes to a different PR. Thank you!
Footnotes
I have plans in mind to make these upgrades more seamless via https://github.com/pyodide/pyodide-actions/issues/12 by letting Dependabot do such a job, but I haven't got around to sitting down and spending a bit of time doing so. ↩