-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect ISO week 53 conversion when only 52 weeks exist #60896
Conversation
Not sure if I'm supposed to be adding the tests in |
You can add a test in |
@pytest.mark.parametrize("errors", ["raise"]) | ||
def test_invalid_iso_week_53(self, msg, s, _format, errors): | ||
# See GH#60885 | ||
with pytest.raises(ValueError, match=msg): | ||
to_datetime(s, format=_format, errors=errors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.parametrize("errors", ["raise"]) | |
def test_invalid_iso_week_53(self, msg, s, _format, errors): | |
# See GH#60885 | |
with pytest.raises(ValueError, match=msg): | |
to_datetime(s, format=_format, errors=errors) | |
def test_invalid_iso_week_53(self, msg, s, _format): | |
# See GH#60885 | |
with pytest.raises(ValueError, match=msg): | |
to_datetime(s, format=_format) |
errors="raise"
is the default so we don't need to specify it here
Thanks @ShashwatAgrawal20 |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.