Skip to content

ENH: clarify error message when getting slice bounds for a non-monotonic index without specifying the label #63397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisvandenbossche merged 12 commits into from
Dec 18, 2025
Merged

ENH: clarify error message when getting slice bounds for a non-monotonic index without specifying the label #63397

jorisvandenbossche merged 12 commits into from
Dec 18, 2025
+22 −9

Conversation

@natmokval
Copy link
Contributor

@natmokval natmokval commented Dec 17, 2025 •
edited
Loading

@natmokval natmokval added Indexing Related to indexing on series/frames, not to indexes themselves Enhancement labels Dec 17, 2025
@natmokval natmokval marked this pull request as draft December 17, 2025 12:50
@natmokval natmokval marked this pull request as ready for review December 17, 2025 14:28
@natmokval natmokval mentioned this pull request Dec 17, 2025
Closed
3 tasks
@mroeschke mroeschke requested a review from rhshadrach December 17, 2025 17:22
@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Dec 17, 2025
rhshadrach
rhshadrach previously requested changes Dec 17, 2025
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@natmokval
Copy link
Contributor Author

natmokval commented Dec 18, 2025

Thanks @rhshadrach for reviewing this PR. I updated the error message in the tests as well.

pre-commit in CI failed, I do not understand why. Locally, the pre-commit checks passed.

jorisvandenbossche
jorisvandenbossche reviewed Dec 18, 2025
View reviewed changes
natmokval and others added 2 commits December 18, 2025 12:57
@natmokval @jorisvandenbossche
Update pandas/core/indexes/base.py
eb5b148 
Co-authored-by: Joris Van den Bossche <[email protected]>
@natmokval
Merge branch 'main' into enh-clarify-error-message-slice-bound-non-mo…
13924c4 
…notonic-index-without-specifying-the-label
jorisvandenbossche
jorisvandenbossche approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit 9694eb1 into pandas-dev:main Dec 18, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach

Assignees

No one assigned

Labels

Enhancement Error Reporting Incorrect or improved errors from pandas Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Series.loc slicing raises KeyError unexpectedly

4 participants

@natmokval @jorisvandenbossche @rhshadrach @mroeschke