-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Express 3.x support #1
Express 3.x support #1
Conversation
I first merged the visionmedia master in order to get all updates from them. After this I reapplied the changes needed for express-resource-middleware.
btw. @visionmedia what do you think about having this feature? Maybe we could even merge this into express-resource? |
I can give you repo access if you're into that |
added |
Thanks. Will add some tests maybe & then commit it. |
Did this ever get merged with visionmedia/express-resource? |
Nope, sorry. |
Ok - thanks for the response. Leaning towards abandoning express-resource myself. I need to implement RESTful HTTP Basic Auth, a simple task that seems to be incredibly difficult to actually implement using any of the existing 'REST' libraries. |
hmm.. didn't do this myself but I assume you looked at Passport.js? |
Yeah, I'm using the Passport.BasicStrategy with Express without issue, however getting it to play nicely with express-resource (Express3) is costing me time I don't have. I attempted to rebase / merge this PR with this one but I get smacked in the face with merge conflicts. I'm going to roll with Passport/Express3 for the time being, perhaps I'll revisit express-resource + middleware support when I get around to refactoring. Thanks anyway. |
Fixed the stuff for express 3.x.