Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express 3.x support #1

Closed
wants to merge 9 commits into from
Closed

Express 3.x support #1

wants to merge 9 commits into from

Conversation

mweibel
Copy link

@mweibel mweibel commented Mar 27, 2013

Fixed the stuff for express 3.x.

@mweibel
Copy link
Author

mweibel commented Mar 28, 2013

btw. @visionmedia what do you think about having this feature? Maybe we could even merge this into express-resource?

@tj
Copy link

tj commented Mar 28, 2013

I can give you repo access if you're into that

@tj
Copy link

tj commented Mar 28, 2013

added

@mweibel
Copy link
Author

mweibel commented Mar 29, 2013

Thanks. Will add some tests maybe & then commit it.

@tthew
Copy link

tthew commented Apr 18, 2013

Did this ever get merged with visionmedia/express-resource?

@mweibel
Copy link
Author

mweibel commented Apr 18, 2013

Nope, sorry.
I actually would have repo access now but since then I moved back to not using express-resource anymore so that's why I didn't merge it..

@tthew
Copy link

tthew commented Apr 18, 2013

Ok - thanks for the response. Leaning towards abandoning express-resource myself. I need to implement RESTful HTTP Basic Auth, a simple task that seems to be incredibly difficult to actually implement using any of the existing 'REST' libraries.

@mweibel
Copy link
Author

mweibel commented Apr 18, 2013

hmm.. didn't do this myself but I assume you looked at Passport.js?

@tthew
Copy link

tthew commented Apr 18, 2013

Yeah, I'm using the Passport.BasicStrategy with Express without issue, however getting it to play nicely with express-resource (Express3) is costing me time I don't have. I attempted to rebase / merge this PR with this one but I get smacked in the face with merge conflicts. I'm going to roll with Passport/Express3 for the time being, perhaps I'll revisit express-resource + middleware support when I get around to refactoring. Thanks anyway.

@mweibel mweibel closed this Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants