-
Notifications
You must be signed in to change notification settings - Fork 725
Debug broken anchor #9494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug broken anchor #9494
Conversation
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9494-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9494-documentation.appa.pantheon.site |
When you refresh the page, the note under the first FAQ is styled correctly for a flash but then goes away Screen.Recording.2025-03-19.at.1.52.27.PM.movThe following anchors do not link to the correct header section:
Since all the impacted headers appear after the unstyled note mentioned at the top of this comment, I'm wondering if the issues are related? I'm not able to reproduce the issues running gatsby locally but I do see it on production and preview environments in multiple browsers @mel-miller this issues was present before our latest PDS toolkit updates but it may be a design issue, could you take a look? |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9494-documentation.appa.pantheon.site |
Cherry picked solution from separate PR (that we're closing as a dupe) into this PR Tested anchors and popups - looks great! thank you so much @gfbollingerHakuna!! |
Fixes #9490
Replaces #9502
Debug broken anchors across traffic intro page, for example:
https://docs.pantheon.io/guides/account-mgmt/traffic#what-about-denial-of-service-and-other-attacks
Bug
The presence of a
Popover
component caused other elements to render incorrectly, wrapping them inside a div with pds-popover classes.Fix
Ensured Popover only renders on the client side using
useState
anduseEffect
, preventing issues during server-side rendering (SSR).