-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle qualifiers for new GAF 2.2 spec #45
Comments
@pgaudet @thomaspd @huaiyumi For exporting the IBAs to GAF 2.2, what should the default qualifiers be by aspect?
Also, if an IBA has a NOT qualifier, it will be included as usual with the "relation" qualifier determined above (e.g. |
I just looked at: http://wiki.geneontology.org/index.php/Involved_in, and the gp -> bp for PAINT should be involved_in |
@thomaspd Sweet! Thanks for straightening this out. And for the existing qualifiers in PAINT ( |
If there already is a qualifier, you keep that qualifier. |
@thomaspd @pgaudet Doh! I just noticed we may be using the wrong default qualifier for CC after rereading this - geneontology/go-annotation#2917 (comment). Should the CC default be |
No, I dont think PAINT should be using default qualifiers. Default qualifiers are used when we are not sure the protein is active in the specified location (or plays part in a process). In PAINT our annotation guidelines are to only propagate CC that are consistent with the role of the protein. Thanks, Pascale |
Actually, looks like 'is_active_in' in allowed, this is the best one for PAINT. |
@pgaudet Thanks! I'll use |
Yes ! |
Commit 732ffe8 prevents new gp2term relations from GAF 2.2 from getting into PAINT and PANTHER. Noting that this is a temporary, short-term (and easily revertible) solution to get the GAF 2.2-sourced annotations into PAINT/PANTHER without mucking up the existing load process. We'll discuss/document the actual policy to implement on a PAINT call. |
Thanks @dustine32 |
From @thomaspd's email:
More info here: geneontology/go-annotation#2917. This has ramifications for both PANTHER and PAINT loads.
PANTHER
It looks like the
genelist_agg
table may need to be adjusted to retain qualifiers with the GO terms associated with a gene. Qualifiers are already somewhat factored into loading thegenelist_agg
table asNOT
annotations are excluded.PAINT
The qualifier column is already parsed and loaded into the Curation DB for GO annotaions. But with more GO annotations having qualifiers that likely won't (initially) match the PAINT annotation qualifiers, mismatches will cause many PAINT annotations to be obsoleted during a full GO update. Maybe we should have some sort of rule-based update followed by manual review for the initial load of the newly formatted GAFs?
It would be nice to get some sample, preview data. Like, an exp GO annotation currently used as evidence in PAINT that also has qualifiers in whatever curation tool it's source from (e.g. Protein2GO).
The GAF creation script likely won't need much modification but I believe there are some regexes used that specifically look for
CONTRIBUTES_TO
andCOLOCALIZES_WITH
.Also tagging @huaiyumi and @mugitty
The text was updated successfully, but these errors were encountered: