Skip to content

PHP 8.1 deprecation notice for Collection::offsetGet() signature #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PHP 8.1 deprecation notice for Collection::offsetGet() signature #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bbb8c4
PHP 8.1 deprecation notice
masroore Jun 6, 2022
eac7bd5
updated composer.json
masroore Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "paquettg/php-html-parser",
"name": "masroore/php-html-parser",
"type": "library",
"description": "An HTML DOM parser. It allows you to manipulate HTML. Find tags on an HTML page with selectors just like jQuery.",
"keywords": ["html", "dom", "parser"],
"homepage": "https://github.com/paquettg/php-html-parser",
"homepage": "https://github.com/masroore/php-html-parser.git",
"license": "MIT",
"authors": [
{
Expand Down
1 change: 1 addition & 0 deletions src/PHPHtmlParser/Dom/Node/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ public function offsetUnset($offset): void
*
* @return mixed
*/
#[\ReturnTypeWillChange]
public function offsetGet($offset)
{
return $this->collection[$offset] ?? null;
Expand Down