Skip to content

hal: Expose only necessary header files #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

hal: Expose only necessary header files #190

wants to merge 1 commit into from

Conversation

Ondraceq
Copy link
Contributor

@Ondraceq Ondraceq commented May 5, 2022

No description provided.

@Ondraceq Ondraceq force-pushed the halExposeLessHeaders branch from 88df453 to b3dec7e Compare May 6, 2022 07:53
@Ondraceq Ondraceq marked this pull request as draft May 6, 2022 07:54
@Ondraceq Ondraceq force-pushed the halExposeLessHeaders branch from b3dec7e to 510c4c9 Compare May 6, 2022 07:58
@Ondraceq
Copy link
Contributor Author

Ondraceq commented May 6, 2022

@yaqwsx Does this change make sense to you? It's a step towards a unified code for physical robots and simulator.

However it doesn't compile since the code is not compatible

@Ondraceq Ondraceq force-pushed the halExposeLessHeaders branch 11 times, most recently from 367597f to c661b55 Compare September 22, 2022 12:32
@Ondraceq Ondraceq mentioned this pull request Sep 22, 2022
Merged
@Ondraceq Ondraceq force-pushed the halExposeLessHeaders branch 7 times, most recently from c5eb728 to 0c018e7 Compare September 22, 2022 14:09
@Ondraceq Ondraceq marked this pull request as ready for review September 22, 2022 14:45
@Ondraceq Ondraceq requested a review from yaqwsx September 22, 2022 14:45
@Ondraceq Ondraceq force-pushed the halExposeLessHeaders branch from 0c018e7 to 957ab3f Compare September 22, 2022 14:54
@Ondraceq Ondraceq force-pushed the halExposeLessHeaders branch from 957ab3f to a8f4712 Compare October 13, 2022 10:34
@Ondraceq
Copy link
Contributor Author

@yaqwsx Wants to move the peripherals from esp++, but it is required to be in a library due to examples/hal/servo, which should maybe be a test rather than an example.

@Ondraceq Ondraceq marked this pull request as draft October 19, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaqwsx yaqwsx Awaiting requested review from yaqwsx

At least 1 approving review is required to merge this pull request.

Assignees

@yaqwsx yaqwsx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ondraceq @yaqwsx