Upgrade prost to 0.8.0 #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make our crates compile with the latest nightly Rust version. Also performs a `cargo update` and regenerate the Protobuf files with the latest version. Signed-off-by: Hugues de Valon <[email protected]>
Member
|
I'm guessing here that the minimum version of Rust we support in the service gets bumped to 1.53? |
Member
Author
Yes! From the issue linked, it was confirmed that we can bump our MSRV in Parsec to 1.53.0 so starting from this crate I will update all the dependant ones and upgrade the PArsec CI system! |
Member
Author
|
We will also be able to remove our |
ionut-arm
approved these changes
Sep 28, 2021
Member
ionut-arm
left a comment
ionut-arm
left a comment
There was a problem hiding this comment.
Yes, let's do this!! I hope the changes in the generated files won't come back to bite us
Signed-off-by: Hugues de Valon <[email protected]>
anta5010
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make our crates compile with the latest nightly Rust version.
Also performs a
cargo updateand regenerate the Protobuf files withthe latest version.
See parallaxsecond/parsec#514