Skip to content

Conversation

@lyonsil
Copy link
Member

@lyonsil lyonsil commented Oct 23, 2025

Trying to clear out various dependabot warnings and packages marked as "extraneous" by npm ls. Also cleaning up a warning about stale "caniuse-lite" browser data.


This change is Reviewable

Copilot AI review requested due to automatic review settings October 23, 2025 17:46
@lyonsil lyonsil requested a review from tjcouch-sil as a code owner October 23, 2025 17:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lyonsil lyonsil changed the title Ran "npm audit fix" and "npm prune" Ran "npm audit fix", "npm prune", and "npx update-browserslist-db@latest" Oct 23, 2025
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this. I don't do pruning lightly so I looked through the changes closely. I can't see anything obvious that would break anything (although breakages aren't usually obvious). :lgtm:

FYI I have been too scared with things breaking to start in the templates. My usual update strategy is update everything in core and check it's all working but don't create the PR yet. Then make the same changes in both templates. Once the template PRs are merged, update them in core, then post its PR.

@irahopkinson reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member Author

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I updated the multi-extension-template, too, per your suggestion. The PR is at paranext/paranext-multi-extension-template#68. That one didn't require npm prune to clean things up like this one did.

I tested the updated package-lock.json files in core and everything seemed to work OK.

Once that PR is approved, I'll merge both.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@tjcouch-sil reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lyonsil lyonsil merged commit f2812c6 into main Oct 27, 2025
5 checks passed
@lyonsil lyonsil deleted the update-package-lock branch October 27, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants