Skip to content

features: Move quic related dependencies under feature flag #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ network-interface = "1.1.1"
parking_lot = "0.12.3"
pin-project = "1.1.0"
prost = "0.12.6"
quinn = { version = "0.9.3", default-features = false, features = ["tls-rustls", "runtime-tokio"], optional = true }
rand = { version = "0.8.0", features = ["getrandom"] }
rcgen = "0.10.0"
ring = "0.16.20"
serde = "1.0.158"
sha2 = "0.10.8"
simple-dns = "0.9.3"
Expand All @@ -47,18 +45,17 @@ hickory-resolver = "0.24.2"
uint = "0.10.0"
unsigned-varint = { version = "0.8.0", features = ["codec"] }
url = "2.5.4"
webpki = { version = "0.22.4", optional = true }
x25519-dalek = "2.0.1"
x509-parser = "0.17.0"
yasna = "0.5.0"
zeroize = "1.8.1"
yamux = "0.13.4"

# Exposed dependencies. Breaking changes to these are breaking changes to us.
[dependencies.rustls]
version = "0.20.7"
default-features = false
features = ["dangerous_configuration"] # Must enable this to allow for custom verification code.
# Quic related dependencies. Quic is an experimental feature flag. The dependencies must be updated.
quinn = { version = "0.9.3", default-features = false, features = ["tls-rustls", "runtime-tokio"], optional = true }
rustls = { version = "0.20.7", default-features = false, features = ["dangerous_configuration"], optional = true }
ring = { version = "0.16.20", optional = true }
webpki = { version = "0.22.4", optional = true }

[dev-dependencies]
asynchronous-codec = "0.7.0"
Expand Down Expand Up @@ -86,7 +83,7 @@ futures_ringbuf = "0.4.0"

[features]
custom_sc_network = []
quic = ["dep:webpki", "dep:quinn"]
quic = ["dep:webpki", "dep:quinn", "dep:rustls", "dep:ring"]
webrtc = ["dep:str0m"]
websocket = ["dep:tokio-tungstenite"]

Expand Down
1 change: 0 additions & 1 deletion src/multistream_select/dialer_select.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ use crate::{

use bytes::BytesMut;
use futures::prelude::*;
use rustls::internal::msgs::hsjoiner::HandshakeJoiner;
use std::{
convert::TryFrom as _,
iter, mem,
Expand Down
Loading