introduce max message size in webrtc config #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mi/buffer-size-webrtc-config # Conflicts: # src/transport/webrtc/opening.rs
| .parse() | ||
| .expect("valid multiaddress")], | ||
| datagram_buffer_size: 2048, | ||
| max_message_size: 512 * 1024, |
Collaborator
There was a problem hiding this comment.
Where this constant is coming from? What is libp2p way of handling this?
What will happen in case of high throughput transfer — shouldn't we be able to parse the payload split over multiple max_message_size buffers?
Collaborator
There was a problem hiding this comment.
Maybe we should make this optional, not entirely sure if this interferes with @timwu20 upcoming work 🤔
Collaborator
There was a problem hiding this comment.
I would suggest hardcoding the constant from libp2p spec, as discussed in #352.
Collaborator
There was a problem hiding this comment.
Oki doki makes sense 🙏 Let's hardcode it instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #352