refactor: implement builder pattern for TransportManager #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Amazing! We'll schedule a review for this week. Thanks for taking a look at this 🙏 |
lexnv
reviewed
Oct 30, 2025
lexnv
reviewed
Oct 30, 2025
lexnv
reviewed
Oct 30, 2025
lexnv
reviewed
Oct 30, 2025
lexnv
reviewed
Oct 30, 2025
lexnv
reviewed
Oct 30, 2025
lexnv
reviewed
Oct 30, 2025
Collaborator
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
Overall looks good! Thanks for contributing 🙏
supported_transports
Contributor
Author
|
Thanks for the review @lexnv. I've pushed fixes for all the issues. |
lexnv
reviewed
Oct 31, 2025
lexnv
approved these changes
Oct 31, 2025
Collaborator
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
LGTM! Thanks again for contributing, this makes the API usage much better 🙏
Contributor
Author
|
ty @dmitry-markin. all fixes pushed |
dmitry-markin
approved these changes
Nov 3, 2025
Collaborator
|
@lexnv IMO the PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the builder pattern for
TransportManager.resolves #343