fix: multistream-select negotiation on outbound substream over webrtc #465
+102
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation, modify multistream protocol message, modify opening based on str0m api changes
haikoschol
force-pushed
the
haiko-webrtc-outbound-multistream-nego-fix
branch
from
93e6151 to
85fae21
Compare
haikoschol
commented
Nov 5, 2025
| protocol: protocol.to_string(), | ||
| }); | ||
|
|
||
| // self.rtc.channel(channel_id).unwrap().set_buffered_amount_low_threshold(1024); |
haikoschol
commented
Nov 5, 2025
| event = self.handles.next() => match event { | ||
| None => unreachable!(), | ||
| Some((channel_id, None | Some(SubstreamEvent::Close))) => { | ||
| Some((_, None)) => {} |
Author
There was a problem hiding this comment.
This is a superficial fix for another unrelated issue which I haven't investigated yet. Without this change, a "channel closed" event is fired repeatedly after a while. I believe this is caused by SubstreamHandle::tx being dropped, presumably when the substream(/channel?) is closed. The fact that the event continues firing suggests that SubstreamHandle::rx continues to be polled. Maybe the handle simply needs to be removed from self.handles?
I've also seen this happen when briefly testing with a rust-libp2p dialer, so this is not related to smoldot interop.
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how multistream-select messages received on an opening outbound substream are handled on webrtc connections. For details please see the issue description.
The PR builds on top of #441 for the str0m update. But looking at it again I realized that it also made changes to multistream-select handling. I'll look into what those are and how they relate to my changes. In any case, I believe my changes bring the implementation closer to compliance with the multistream-select spec and enable interoperability with smoldot.
fixes #464