Stop leaking hickory error types in litep2p public API - #643
Merged
Conversation
gab8i
approved these changes
Aug 17, 2026
dmitry-markin
added a commit
that referenced
this pull request
Aug 17, 2026
## [0.15.0] - 2026-08-17 This release focuses on WebRTC. It is the first release with official WebRTC support. Expect things to break and get fixed in subsequent point releases. This release is also semver breaking on the error API. `Error::CannotReadSystemDnsConfig` now carries an opaque `DnsInitError` instead of a `hickory-resolver` error type, and the new `Error::DnsResolverInit` variant reports resolver construction failures. `Error` is now `#[non_exhaustive]`, so external `match` expressions over it require a wildcard arm. Together these changes keep `hickory-resolver` out of the public API, making future resolver bumps semver compatible. ### Added - webrtc: support wildcard listen addresses ([#640](#640)) - bitswap: enable Keccak and BLAKE2b hashers for CIDs ([#641](#641)) ### Changed - deps: bump hickory-resolver and str0m ([#642](#642)) - deps: bump str0m to 0.22 ([#639](#639)) - webrtc: use a shared 16 KiB buffer for the `WebRtcTransport` stream ([#623](#623)) ### Fixed - dns: stop leaking hickory error types in litep2p's public API ([#643](#643)) - webrtc: enforce strict client network identity verification ([#637](#637)) - webrtc: fix input backpressure ([#626](#626)) - webrtc: properly handle `str0m::Event::Closed` ([#627](#627)) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dmitry Markin <dmitry@markin.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what happened in litep2p <= v0.14.3 and forces us now to go to v0.15 because of the changes in hickory error types. Stop leaking so we can tolerate future hickory error type changes.
Also mark litep2p
Erroras non-exhaustive, so it can be safely extended in the future.